Skip to content

fix: prevent invalid min/max params for integer attributes#2843

Merged
HarshMN2345 merged 5 commits intomainfrom
fix-integer-attribute-min-max-casting
Feb 10, 2026
Merged

fix: prevent invalid min/max params for integer attributes#2843
HarshMN2345 merged 5 commits intomainfrom
fix-integer-attribute-min-max-casting

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Feb 9, 2026 •
edited by coderabbitai bot
Loading

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

before

image

after

image

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Chores

    • Updated UI component packages to new pinned versions.

  • Refactor

    • Reordered keys in a database column update payload; no behavioral change to the public API or submit actions.

@appwrite
Copy link

appwrite bot commented Feb 9, 2026 •
edited
Loading

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc		 Ready Ready View Logs Preview URL QR Code

Tip

Git integration provides automatic deployments with optional PR comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026 •
edited
Loading

Warning

Rate limit exceeded

@HarshMN2345 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

This pull request includes two minor updates: a reordering of the xdefault field in the updateFloat payload within the float.svelte component (moving it from after the required field to after the max field), and version updates to two dependencies in package.json by swapping commit hashes for @appwrite.io/pink-icons-svelte and @appwrite.io/pink-svelte. No functional behavior changes are introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'integer attributes' but the actual changes modify float column handling and package dependencies, not integer attribute validation. Update the title to accurately describe the changes, such as 'Reorder xdefault field in float column update payload and upgrade dependencies' or investigate if the PR contains unrelated changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-integer-attribute-min-max-casting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HarshMN2345 HarshMN2345 merged commit 3daf2d4 into main Feb 10, 2026
4 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-integer-attribute-min-max-casting branch February 10, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ItzNotABug ItzNotABug ItzNotABug approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HarshMN2345 @ItzNotABug